Click to open network menu
Join or Log In
Smitefire logo

Join the leading League of Legends community. Create and share Champion Guides and Builds.

Create an MFN Account






Or

's Forum Avatar

My guide won't save

Creator: megozn1k April 24, 2017 4:59am
10 posts - page 1 of 1
megozn1k
<Member>
megozn1k's Forum Avatar
Show more awards
Posts:
70
Joined:
Sep 26th, 2014
Permalink | Quote | PM | +Rep April 24, 2017 4:59am | Report
Today I was finishing my s7 update for Nasus guide and it won't save.

It's rly annoying as I had to copy paste everything to .txt file to just save most of the changes i made.

As my Nasus guide is one of the most clickable there is you should really do something about it.

its 100% not my connection, nor the browser - tried both ie and ff.

The circle just spins for eternity there and if I try to overstep it with publish i get a bug error that i need to have at least 1 chapter.

I understand that my guide is massive in terms of raw text, still this should not be happening.

Fix please.
Mowen
<Production Coordinator>
Mowen's Forum Avatar
Show more awards
Posts:
6443
Joined:
Nov 7th, 2010
Permalink | Quote | PM | +Rep April 24, 2017 8:52am | Report
Hey, just wanted to let you know we are looking into this and will get back to you!
megozn1k
<Member>
megozn1k's Forum Avatar
Show more awards
Posts:
70
Joined:
Sep 26th, 2014
Permalink | Quote | PM | +Rep April 25, 2017 7:09am | Report
The problem persists.
Swuft
<Fabulous>
Swuft's Forum Avatar
Show more awards
Posts:
222
Joined:
Oct 18th, 2015
Permalink | Quote | PM | +Rep April 25, 2017 8:32pm | Report
Yeah I have the same problem here. I am unable to get any updates for my guide to save/publish. I first had this occur to me on April 18th, but assumed it was just my 'net being slow. Clearly this is not the case however. This is the text I get when I try to save/publish:

"Error: There was a problem saving your guide. Make sure you have created at least one chapter with a title and some text, and then try again."

Please fix ;(
Matt
<Administrator>
Matt's Forum Avatar
Show more awards
Posts:
4286
Joined:
Dec 8th, 2009
Permalink | Quote | PM | +Rep April 25, 2017 10:07pm | Report
I just pushed some optimizations. @ megozn1k you have a chapter that is over 150k in size and it was causing some performance issues during the save process (a lot goes on in the back-end while saving), leading to your save request timing out. We've done some work to speed it up so go try now and let me know if it's improved.

@ Swuft you likely had a similar issue, try again now and let me know if it works.
jhoijhoi
<MOBAFire Mother>
jhoijhoi's Forum Avatar
Show more awards
Posts:
14418
Joined:
Mar 20th, 2011
Permalink | Quote | PM | +Rep April 26, 2017 4:16am | Report
@ Matt So these issues were brought about due to issues with one-chapter massive guides? I never really cared or thought about it often when I followed the trend of one-chapter guides, but new users probably get hit by a whole lot of loading when they first view such a guide.

Will restrictions be put into place in the future to prevent one-chapter guides? Or will we continue to have the ability to create our own ToC and such, as opposed to using MobaFire's preset ToC and chapter system?
megozn1k
<Member>
megozn1k's Forum Avatar
Show more awards
Posts:
70
Joined:
Sep 26th, 2014
Permalink | Quote | PM | +Rep April 26, 2017 10:00am | Report
Thanks, now its working.

Right, its the matchups section.

I can devide it into more chapters like champs A to D, E to G etc. Will that speed loading up for the readers?
Swuft
<Fabulous>
Swuft's Forum Avatar
Show more awards
Posts:
222
Joined:
Oct 18th, 2015
Permalink | Quote | PM | +Rep April 26, 2017 10:36am | Report
Yep everything appear to be fine and dandy now. I also have 1 massive chapter for everything (using BBCode stuff to separate things in the guide), but whatever you changed appears to have fixed the issue.

I'm glad there was a workaround because having 1 chapter and using BBCode divisions looks/flows much better than the normal chapter dividers.

EDIT: If restrictions are put in place on 1 chapter guides, as jhoijhoi mentioned, I hope more options will be provided to customize chapter dividers.
PsiGuard
<Retired Admin>
PsiGuard's Forum Avatar
Show more awards
Posts:
10285
Joined:
Jun 26th, 2011
Permalink | Quote | PM | +Rep April 26, 2017 4:59pm | Report
@ jhoijhoi We don't have any plans currently to implement such restrictions. A lot of guide authors use single chapters at the moment so that'd be pretty disastrous if we did so suddenly.

@ megozn1k I believe it will speed up the save time for you but not the load time for readers.

@ Swuft I can't promise anything, but we have talked about improving chapter tools before. I think it would be a great improvement too. :)
Thanks to Janitsu for the sig!
Matt
<Administrator>
Matt's Forum Avatar
Show more awards
Posts:
4286
Joined:
Dec 8th, 2009
Permalink | Quote | PM | +Rep April 26, 2017 6:24pm | Report
As PsiGuard said, these changes only affect SAVING guides, not viewing. When you save your guide there are a number of things that happen, such as spam checks, that are fairly intensive. I'm not sure splitting that large chapter up in to multiple chapters will make it any faster, in this case the checks are pretty linear in terms of performance, so you're fine the way it is. We have done some optimizations to speed it up enough that even large guides should be able to save, even if it still takes several seconds.

In terms of performance for your readers, chapters and bbcode don't make a difference (that all happens server side and gets cached for speed), but images do. Some people go overboard with images, loading megabytes upon megabytes of them. Authors should look at the overall download size of their guide and be sure to optimize their images where possible to make them load faster and eat up less bandwidth.

You need to log in before commenting.

League of Legends Champions:

Teamfight Tactics Guide